Skip to content

[Offload][NFC] Re-enable clang-format for omptarget.h #152937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 10, 2025

Conversation

kevinsala
Copy link
Contributor

No description provided.

@llvmbot
Copy link
Member

llvmbot commented Aug 10, 2025

@llvm/pr-subscribers-offload

Author: Kevin Sala Penades (kevinsala)

Changes

Full diff: https://github.com/llvm/llvm-project/pull/152937.diff

1 Files Affected:

  • (modified) offload/include/omptarget.h (+2)
diff --git a/offload/include/omptarget.h b/offload/include/omptarget.h
index 6971780c7bdb5..f1a67dbd2acf5 100644
--- a/offload/include/omptarget.h
+++ b/offload/include/omptarget.h
@@ -269,6 +269,8 @@ struct __tgt_target_non_contig {
   uint64_t Stride;
 };
 
+// clang-format on
+
 #ifdef __cplusplus
 extern "C" {
 #endif

Copy link
Contributor

@jhuber6 jhuber6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just enable it for the whole file? All it guards is the enums being aligned by = which I think is fine to do without.

@kevinsala
Copy link
Contributor Author

@jhuber6 LGTM applying clang-format in the whole file. Actually, it was the only file in offload that disabled clang-format apart from the tests.

@kevinsala kevinsala merged commit 5751e96 into llvm:main Aug 10, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants